----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24191/#review49378 -----------------------------------------------------------
Ship it! Looks good. +1 - Tom Beerbower On Aug. 1, 2014, 8:09 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24191/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 8:09 p.m.) > > > Review request for Ambari, Sid Wagle and Tom Beerbower. > > > Bugs: AMBARI-6717 > https://issues.apache.org/jira/browse/AMBARI-6717 > > > Repository: ambari > > > Description > ------- > > Adds alerting SQL to Oracle and MySQL and also upgrades existing databases. > This is required since we defined entities in the persistence.xml, even > though alerts aren't shipping for a while. We could have removed the entities > from persistence.xml, but then unit tests would start to fail. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java > c13b742 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7333919 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 5698c5d > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql dbb55e8 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 4e0e912 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java > e74f257 > > Diff: https://reviews.apache.org/r/24191/diff/ > > > Testing > ------- > > mvn clean test > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 16:52.179s > [INFO] Finished at: Fri Aug 01 16:09:43 EDT 2014 > [INFO] Final Memory: 22M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
