----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24612/#review50444 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/yaml_config.py <https://reviews.apache.org/r/24612/#comment88217> This is more appropriate use arg here not kwarg, since when not provided configurations this is probably an invalid/unhandled situation. ambari-server/src/test/python/stacks/utils/RMFTestCase.py <https://reviews.apache.org/r/24612/#comment88219> do we really need this? ambari-server/src/test/python/stacks/utils/RMFTestCase.py <https://reviews.apache.org/r/24612/#comment88218> I don't think It's a good idea to add this here, it's only hack for Storm it won't work for others since yaml_config.py is not found, it also not logically correct. To me it won't be a big code duplication to copy that 3 lines to the storm scripts. Also have you tested Storm deploy, since Storm scripts were changed. - Andrew Onischuk On Aug. 12, 2014, 6:30 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24612/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 6:30 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-6833 > https://issues.apache.org/jira/browse/AMBARI-6833 > > > Repository: ambari > > > Description > ------- > > Fix unitests for issue - AMBARI-6748 Nimbus start failed after deployment > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/yaml_config.py > 39261be > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py > c07ce72 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 5658d62 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py > 158fdc1 > > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py > 2684079 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py > 6faead0 > > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py > 574e7c2 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py > 1c5e755 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 831c449 > > Diff: https://reviews.apache.org/r/24612/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 222 tests in 0.627s > > OK > ---------------------------------------------------------------------- > Total run:564 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > >
