----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24742/#review50735 -----------------------------------------------------------
Change looks good, however can you quickly expalin why Flume needs to be STOPPED even though it is already in INSTALLED state? - Sid Wagle On Aug. 15, 2014, 4:41 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24742/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 4:41 p.m.) > > > Review request for Ambari, Srimanth Gunturi and Sid Wagle. > > > Bugs: AMBARI-6876 > https://issues.apache.org/jira/browse/AMBARI-6876 > > > Repository: ambari > > > Description > ------- > > Due to a refactor, the code that picked up state changes for targeted host > components was no longer getting invoked. This patch addresses that. > > In the case where you issue a STOP on a host component and you supply > information for the host component (as with Flume), the command should be > sent down even if the state of that host component is already stopped. The > refactor skips this case. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 59544dd > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > fe2023e > > Diff: https://reviews.apache.org/r/24742/diff/ > > > Testing > ------- > > Added test case > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:51.784s > [INFO] Finished at: Fri Aug 15 11:50:31 EDT 2014 > [INFO] Final Memory: 19M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
