----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24886/#review51096 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Aug. 20, 2014, 12:20 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24886/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 12:20 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi. > > > Bugs: AMBARI-6935 > https://issues.apache.org/jira/browse/AMBARI-6935 > > > Repository: ambari > > > Description > ------- > > Currently stack API exposes component level dependencies which does not roll > up to service level dependency is required for restricting user to install a > service that cannot work in the absence of a dependent service. > > Currently there is a hard-coded map in the ambari-web code for service > dependency which restricts this validation functionality to only known > services of HDP stack. > service dependency map: > > > > > HDP-1: { > HDFS: ['MAPREDUCE', ''HBASE', SQOOP'], > MAPREDUCE: ['PIG', 'OOZIE', 'HIVE'], > ZOOKEEPER: ['HBASE', 'HIVE', 'WEBHCAT'], > HIVE: ['HCATALOG','WEBHCAT'] > }, > HDP-2: { > ZOOKEEPER: ['HDFS', 'HBASE', 'HIVE', 'WEBHCAT', 'STORM'] > HDFS: ['YARN', 'HBASE', 'FLUME', 'SQOOP'], > YARN: [ 'MAPREDUCE2', 'PIG', 'OOZIE', 'HIVE', 'TEZ'], > TEZ: ['YARN', 'HIVE'], > OOZIE: ['FALCON'], > HIVE: ['HCATALOG','WEBHCAT'] > } > > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java > 0670d9c > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > 25b3b8d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 0523edc > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > ac1c9b5 > ambari-server/src/main/resources/properties.json aa2bf71 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/metainfo.xml > d1e8795 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/metainfo.xml > c1263d5 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/metainfo.xml > a900f2e > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/metainfo.xml > 4e83703 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/metainfo.xml > e7f0cad > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/SQOOP/metainfo.xml > 1f835cb > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/metainfo.xml > 636f499 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml > 4011c28 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml > c63b2b8 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml > 62b7cd8 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml > eecc292 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml > bdc83ea > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/metainfo.xml > 48b42f1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/metainfo.xml > 4573211 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/metainfo.xml > 325fddf > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml > 8bb8dd7 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/metainfo.xml > 43c2a3e > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/metainfo.xml > 3f13983 > ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/metainfo.xml > e6ffd18 > > ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java > 517f3b7 > > ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/metainfo.xml > c114c83 > > Diff: https://reviews.apache.org/r/24886/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
