----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24888/#review51098 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Aug. 20, 2014, 9:53 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24888/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 9:53 a.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-6939 > https://issues.apache.org/jira/browse/AMBARI-6939 > > > Repository: ambari > > > Description > ------- > > STR: > 1. Create view instances with specific view instance parameters. > 2. Issue "ambari-server restart" > 3. All the view instances have lost their parameters. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > 036fa13 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 65a48b4 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > 21a00ed > > Diff: https://reviews.apache.org/r/24888/diff/ > > > Testing > ------- > > Manual testing with STR above. > > Updated unit tests. All existing tests pass. > > Results : > > Tests run: 1943, Failures: 0, Errors: 0, Skipped: 15 > > … > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:14.646s > [INFO] Finished at: Wed Aug 20 08:11:35 EDT 2014 > [INFO] Final Memory: 37M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
