----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24927/#review51170 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Aug. 21, 2014, 12:28 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24927/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 12:28 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-6971 > https://issues.apache.org/jira/browse/AMBARI-6971 > > > Repository: ambari > > > Description > ------- > > Currently we are checking for oraclelinux where we don't use ulimit. > As I talked to dshkvyra it was though that it doesn't work on oraclelinux. > But the reason why it didn't work was that it was executed as hdfs user. > Now when have it executed from root (which is fixed in ) we can remove the > check, I tested the command on oraclelinux it works well. > Also even if it won't work in some strange reason that won't fail the start > command and have the same impact as now. > This fixes unittests issue when os_type sometimes didn't mock, as well as > ulimit on oraclelinux > > Ulimit on oraclelinux checked: > > > > [root@dev-oracle-linux ~]# ulimit -c unlimited > [root@dev-oracle-linux ~]# ulimit -c > unlimited > [root@dev-oracle-linux ~]# > > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py > c68c982 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py > 6ad04b3 > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py dda75ea > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py eec22d1 > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_snamenode.py f427096 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 807d3b9 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py a28410e > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 1878d87 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 04fbf94 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 30ae794 > > Diff: https://reviews.apache.org/r/24927/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
