-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26017/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sid Wagle.
Bugs: AMBARI-7481
https://issues.apache.org/jira/browse/AMBARI-7481
Repository: ambari
Description
-------
The LDAP sync API does not expose sync for existing users and groups even
though it is supported by the back end code.
"ambari-server sync-ldap --existing" which would would first look at the ambari
database and only clean-up those users and groups. This way, it doesn't pull
any new ones, it a) removes users that are in ambari but out of ldap, b) remove
groups that are in ambari but out of ldap and c) syncs the group membership of
the groups that are in ambari
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
b932cbb
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
8c0dfeb
ambari-server/src/main/java/org/apache/ambari/server/controller/LdapSyncRequest.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ControllerResourceProvider.java
129824f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
99ac0f1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java
188c071
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PermissionDAO.java
97af522
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/LdapSyncEventEntity.java
9ce3ee0
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/LdapSyncSpecEntity.java
027a4ce
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
ecc2c0d
ambari-server/src/test/java/org/apache/ambari/server/controller/LdapSyncRequestTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProviderTest.java
92bd7a4
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/LdapSyncEventEntityTest.java
66f9d6d
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/LdapSyncSpecEntityTest.java
468281f
Diff: https://reviews.apache.org/r/26017/diff/
Testing
-------
Manual tests.
Added new unit tests. All existing tests pass ...
Results :
Tests run: 2069, Failures: 0, Errors: 0, Skipped: 16
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:18.831s
[INFO] Finished at: Wed Sep 24 17:39:44 PDT 2014
[INFO] Final Memory: 45M/433M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
