> On Oct. 10, 2014, 10:02 a.m., Tom Beerbower wrote: > > Looks good. A couple of comments. > > > > Please make sure to doc all public methods, classes and interfaces. > > > > I'm still not sure about the name 'status' for a resource that is basically > > a collection of static properties. To me 'status' is something that can > > change (i.e. GOOD to BAD). It's up to you. I'm okay with it if it makes > > sense for the JOBS view.
I see your point. I'm following the same precedence that the Slider view has. I can call it "static", "properties", or "parameters", unless we may expect to put other things in there in the future. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26540/#review56114 ----------------------------------------------------------- On Oct. 10, 2014, 4:46 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26540/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 4:46 a.m.) > > > Review request for Ambari, Srimanth Gunturi and Tom Beerbower. > > > Bugs: AMBARI-7719 > https://issues.apache.org/jira/browse/AMBARI-7719 > > > Repository: ambari > > > Description > ------- > > Jobs view should provide the view parameters as internal resource. For this, > we need API > http://server:8080/api/v1/views/JOBS/versions/1.0.0/instances/sv1/resources/status > which will provide below response. > parameters: { > "yarn.ats.url" : "http://server:8188";, > "yarn.resourcemanager.url" : "http://server:8088"; > } > > > Diffs > ----- > > contrib/views/jobs/pom.xml f2173e3 > > contrib/views/jobs/src/main/java/org/apache/ambari/view/jobs/ViewController.java > PRE-CREATION > > contrib/views/jobs/src/main/java/org/apache/ambari/view/jobs/ViewControllerImpl.java > PRE-CREATION > > contrib/views/jobs/src/main/java/org/apache/ambari/view/jobs/ViewStatus.java > PRE-CREATION > > contrib/views/jobs/src/main/java/org/apache/ambari/view/jobs/rest/ViewStatusResource.java > PRE-CREATION > contrib/views/jobs/src/main/resources/view.xml 6dd5ee6 > > Diff: https://reviews.apache.org/r/26540/diff/ > > > Testing > ------- > > Deployed the view and ensured that could access the URL > http://server:8080/api/v1/views/JOBS/versions/1.0.0/instances/sv1/resources/status > which displayed > parameters: { > "yarn.ats.url" : "http://server:8188";, > "yarn.resourcemanager.url" : "http://server:8088"; > } > > > Thanks, > > Alejandro Fernandez > >
