----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26568/ -----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower. Bugs: AMBARI-7734 https://issues.apache.org/jira/browse/AMBARI-7734 Repository: ambari Description ------- Alert history is exposed as read-only. Since this data can grow without bounds, the current API model of manipulating the entire result set in memory is not viable long term. This patch will pass the Ambari Predicate down to the DAO which will then turn the Predicate into a JPA Predicate capable of being handed to a CriteriaQuery. This will allow JPA to do most of the work in reducing the requested result set. Missing from this are pagination and sorting. That will be a separate change coming next where the ResourceProviders are given both, and if possible, can apply them to the result set they return. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/api/query/JpaPredicateVisitor.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertHistoryResourceDefinition.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 74580a4 ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertHistoryService.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java a56bcbf ambari-server/src/main/java/org/apache/ambari/server/controller/AlertHistoryRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java e0de383 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 5810633 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java f51375b ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java f2161f3 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity_.java PRE-CREATION ambari-server/src/main/resources/key_properties.json 085dc11 ambari-server/src/main/resources/properties.json 8a0a58a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProviderTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java a2023d8 Diff: https://reviews.apache.org/r/26568/diff/ Testing ------- [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 23:24 min [INFO] Finished at: 2014-10-10T14:45:44-04:00 [INFO] Final Memory: 29M/230M [INFO] ------------------------------------------------------------------------ Thanks, Jonathan Hurley