> On Oct. 16, 2014, 5:09 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/service_check.py, > > line 35 > > <https://reviews.apache.org/r/26803/diff/1/?file=722906#file722906line35> > > > > Should have a timeout here. Look at > > ambari-common/src/main/python/resource_management/core/shell.py, this is > > called by "Execute" resurce and give you a timeout option. > > Sriharsha Chintalapani wrote: > so metainfo.xml has the timeout <commandScript> > <script>scripts/service_check.py</script> > <scriptType>PYTHON</scriptType> > <timeout>300</timeout> > </commandScript> > do we need to worry about timeout in the service_check.py
Ok that's good enough, otherwise its a bug in Ambari. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26803/#review56933 ----------------------------------------------------------- On Oct. 16, 2014, 6:11 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26803/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 6:11 a.m.) > > > Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-7807 > https://issues.apache.org/jira/browse/AMBARI-7807 > > > Repository: ambari > > > Description > ------- > > This task includes kafka service provisioning via Ambari. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php > 878f0dc > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py > e1100c4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 > 0aa4b68 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > 1ed55d1 > ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json > f8eb4c7 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-broker.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-log4j.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka_broker.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/properties_config.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/status_params.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.2/configs/default.json 5e984fe > ambari-web/app/data/HDP2/site_properties.js f6b1862 > ambari-web/app/models/service_config.js 664ca62 > ambari-web/app/models/stack_service.js 7f64212 > > Diff: https://reviews.apache.org/r/26803/diff/ > > > Testing > ------- > > tested e2e on HDP-2.2 stack > > > Thanks, > > Jaimin Jetly > >
