> On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml, > > lines 18-23 > > <https://reviews.apache.org/r/27206/diff/2/?file=734106#file734106line18> > > > > Should be 2 space indent
Oops... forgot to configure IntelliJ XML formatting.. :( > On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py, > > line 26 > > <https://reviews.apache.org/r/27206/diff/2/?file=734107#file734107line26> > > > > Does the client require krb5-server? The client does not require the server, hence the exclustion of the server-specific packages. > On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py, > > lines 30-36 > > <https://reviews.apache.org/r/27206/diff/2/?file=734108#file734108line30> > > > > There seems to be a lot of these - they're typically pre-determined in > > a params.py file. Can these not be done like with the other components? My way _felt_ safter, but I can try to recode to use the param.py file method. > On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py, > > lines 255-269 > > <https://reviews.apache.org/r/27206/diff/2/?file=734108#file734108line255> > > > > Can this be abstracted out via params.py? I'll look into this. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27206/#review58645 ----------------------------------------------------------- On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27206/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 10:37 a.m.) > > > Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku > Sako. > > > Bugs: AMBARI-7448 > https://issues.apache.org/jira/browse/AMBARI-7448 > > > Repository: ambari > > > Description > ------- > > Create a service to manage the (optional) Kerberos server (managed KDC) and > client components in the HDP 2.2 stack. > > See [Ambari Cluster Kerberization Technical > Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) > for more information. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27206/diff/ > > > Testing > ------- > > Added new unit test - > `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest` > > > Thanks, > > Robert Levas > >
