----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27590/#review59911 -----------------------------------------------------------
Ship it! Looks good Nate. So is this purely a placeholder API or is there a good chance that this will remain as the basis for the upgrade API going forward? I know that you had talked to John about some overlap with APIs that he may need. Also, the StaticallyInject notation is a clever way to deal with that mess. I appreciate it since I'm guilty of just following that bad pattern over and over again. I wonder though if we could have used @Singleton and the existing injection mechanism for most or all of these without introducing a new injection annotation. In other words, I think most of these could be singletons instead of non-singletons with static injection points. I don't think that we ever create more than one instance of any resource provider type, for example. - Tom Beerbower On Nov. 4, 2014, 9:55 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27590/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 9:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom > Beerbower. > > > Bugs: AMBARI-8144 > https://issues.apache.org/jira/browse/AMBARI-8144 > > > Repository: ambari > > > Description > ------- > > Added stubs for /api/v1/clusters/c1/upgrades > > This test does not provide full DB connectivity. It's only meant to unblock > other teams from having an endpoint to work with. There will be many many > more changes over the course of the Upgrades initiative > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/StaticallyInject.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > f5de481 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeItemResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > ab71ce2 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeItemService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 14e5dc8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 0974f6f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > de63db5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > b665813 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27590/diff/ > > > Testing > ------- > > Only basic test added, more to come as functionality fills out. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:48.302s > [INFO] Finished at: Tue Nov 04 16:54:11 EST 2014 > [INFO] Final Memory: 29M/248M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
