----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27819/#review60636 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/CrudDAO.java <https://reviews.apache.org/r/27819/#comment102006> Generics typically don't get a huge name, so maybe use E/P, or E/K or something - Nate Cole On Nov. 10, 2014, 1:34 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27819/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 1:34 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-8211 > https://issues.apache.org/jira/browse/AMBARI-8211 > > > Repository: ambari > > > Description > ------- > > Create the following API: DELETE /api/v1/repository_versions/1 > PUT /api/v1/repository_versions/1 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java > f9e8885 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > 6fb1448 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/CrudDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java > f0dcb44 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java > 9daa70e > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > f0a0695 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 8e14bc1 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 641e3f0 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > a8b92e7 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryVersionServiceTest.java > 94b4963 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > 9dc4996 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/CrudDAOTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java > 7dd3fab > > Diff: https://reviews.apache.org/r/27819/diff/ > > > Testing > ------- > > Total run:693 > Total errors:0 > Total failures:0 > > Results : > > Tests run: 2218, Failures: 0, Errors: 0, Skipped: 14 > > > Thanks, > > Yurii Shylov > >
