-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27877/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-8281
    https://issues.apache.org/jira/browse/AMBARI-8281


Repository: ambari


Description
-------

Currently all properties except _content_ one from *-env.xml configurations 
files should be duplicated in _ambari-web/app/data/HDP2/site_properties.js_ .
Otherwise they are ignored on service deploy (not added to ambari configs).

More details:
It looks like UI has some property values for services hardcoded and hidden 
from user. These include _hbase.tmp.dir_ and bunch of others.
When user makes changes to configs these properties are added to corresponding 
configs and sent to server.
Issue is that UI probably filters them by property name only, so if other 
service has property with same name, this property will not be shown to user 
and, which is more important, will not be sent to server as it is wired to 
another service.

We are adding new service which contains embedded hbase, so we have config with 
all duplicated hbase properties, as result it is impossible to create correct 
configuration via UI.


Diffs
-----

  ambari-web/app/data/BIGTOP/site_properties.js c2291b7 
  ambari-web/app/data/HDP2.2/site_properties.js 9c38cde 
  ambari-web/app/data/HDP2/site_properties.js 63ed001 
  ambari-web/app/data/site_properties.js 4151250 
  ambari-web/app/utils/config.js 470d42b 
  ambari-web/test/mock_data_setup/configs_mock_data.js 64cc619 
  ambari-web/test/utils/config_test.js 5dec0ae 

Diff: https://reviews.apache.org/r/27877/diff/


Testing
-------

  5027 tests complete (6 seconds)
  60 tests pending


Thanks,

Andriy Babiichuk

Reply via email to