----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27901/#review60981 -----------------------------------------------------------
Ship it! It would be nice if all of the keywork cases were the same... other than that this is really nice. - Robert Levas On Nov. 11, 2014, 9:09 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27901/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 9:09 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-8292 > https://issues.apache.org/jira/browse/AMBARI-8292 > > > Repository: ambari > > > Description > ------- > > The DDL scripts have the CREATE TABLE statements on a single line, which > makes them difficult to read and compare during code reviews because they > exceed 80 characters. > > > Diffs > ----- > > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql dc58b81 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 1857f8e > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9b7f6a1 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 7eb0b48 > > Diff: https://reviews.apache.org/r/27901/diff/ > > > Testing > ------- > > This is purely a formatting change. > > > Thanks, > > Alejandro Fernandez > >