----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27998/#review61277 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Nov. 13, 2014, 12:42 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27998/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 12:42 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-8314 > https://issues.apache.org/jira/browse/AMBARI-8314 > > > Repository: ambari > > > Description > ------- > > Add some validation when creating a repo version: > * validate the stack exists > * upgrade pack specified is available for the stack > * validate the OS specified for repositories are all in the stack available > * validate that the version specified is valid for the upgrade pack. this > will involve changing the upgrade pack "target" element to a regex > appropriately > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > 502a94e > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > 2debfd3 > > Diff: https://reviews.apache.org/r/27998/diff/ > > > Testing > ------- > > in progress > > > Thanks, > > Yurii Shylov > >
