----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28124/#review62330 -----------------------------------------------------------
Ship it! I think this looks pretty good overall. One minor nit that can be addressed later. Please wait for comments, especially from Tom or John before it gets pushed. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java <https://reviews.apache.org/r/28124/#comment104361> I actually don't see anything injected here, so no need for this (a resource provider is explicitly constructed) - Nate Cole On Nov. 19, 2014, 12:41 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28124/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:41 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate > Cole, and Tom Beerbower. > > > Bugs: AMBARI-8353 > https://issues.apache.org/jira/browse/AMBARI-8353 > > > Repository: ambari > > > Description > ------- > > Add stack_versions subresource to /hosts and /clusters > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java > ef907c0 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java > 14ed799 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 9ad37ec > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > f75ae11 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > c51722c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java > 212f944 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > c198dd6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > 8f10143 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java > 1442a0c > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > dbac906 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java > e2a2e2d > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java > 8d147a1 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java > aaf8eed > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > 5b1b4f8 > > ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java > 72cd541 > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java > 7296e8d > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java > c0e625a > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > e8ce2f7 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java > 42bf009 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java > 93f78b2 > > Diff: https://reviews.apache.org/r/28124/diff/ > > > Testing > ------- > > in progress > > > Thanks, > > Yurii Shylov > >
