> On Nov. 20, 2014, 7:02 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py, > > line 26 > > <https://reviews.apache.org/r/28277/diff/1/?file=770968#file770968line26> > > > > My preference is to use named imports since it makes it easier to find > > where objects are coming from.
I also like this approach (especially because IDEA is not able to perform dynamic imports properly). - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28277/#review62383 ----------------------------------------------------------- On Nov. 20, 2014, 6:12 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28277/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 6:12 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii > Shylov. > > > Bugs: AMBARI-8392 > https://issues.apache.org/jira/browse/AMBARI-8392 > > > Repository: ambari > > > Description > ------- > > From the creation of and upgrade and upgrade items, add the workflow to make > request/stages/tasks out of them (even if they're currently incomplete). > > Stages are not completely finished, as this patch was getting too large to > include that work. This addresses using a custom action for tasks (the > custom task itself is another effort). Creating proper RESTART commands is > also another effort. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java > ee64c0d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 006ab9f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStageContainer.java > 512ea14 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 4746155 > > ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml > fb362cc > ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 15db70e > > Diff: https://reviews.apache.org/r/28277/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:30.942s > [INFO] Finished at: Thu Nov 20 01:05:35 EST 2014 > [INFO] Final Memory: 32M/611M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >