----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28405/#review62998 -----------------------------------------------------------
Ship it! Looks good to me - I'm assuming this will work parallel across all hosts? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java <https://reviews.apache.org/r/28405/#comment105169> No sysout here. - Nate Cole On Nov. 24, 2014, 3:50 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28405/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 3:50 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov. > > > Bugs: AMBARI-8434 > https://issues.apache.org/jira/browse/AMBARI-8434 > > > Repository: ambari > > > Description > ------- > > Preview version of patch. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java > ed94877 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java > 86a00a8 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java > fc1b515 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > 5af88a8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 8f90cf4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 0fc590e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > d0ce1cf > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > 67e62d7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java > de1c9dd > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionData.java > PRE-CREATION > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 850f079 > > ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelperTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28405/diff/ > > > Testing > ------- > > manual verification on 2-node cluster > > proper unit test coverage is pending > > > Thanks, > > Dmitro Lisnichenko > >