----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28522/#review63370 -----------------------------------------------------------
Ship it! Just some minor stuff. ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeGroupService.java <https://reviews.apache.org/r/28522/#comment105595> import not used ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java <https://reviews.apache.org/r/28522/#comment105592> imports not used. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java <https://reviews.apache.org/r/28522/#comment105593> imports not used. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java <https://reviews.apache.org/r/28522/#comment105594> missing description. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java <https://reviews.apache.org/r/28522/#comment105597> variable upgradeId is no longer used. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java <https://reviews.apache.org/r/28522/#comment105591> Unused import. Same for import javax.persistence.FetchType; ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java <https://reviews.apache.org/r/28522/#comment105596> Not used. - Tom Beerbower On Nov. 28, 2014, 2:03 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28522/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2014, 2:03 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Tom > Beerbower, and Yurii Shylov. > > > Bugs: AMBARI-8464 > https://issues.apache.org/jira/browse/AMBARI-8464 > > > Repository: ambari > > > Description > ------- > > This addresses a new requirement of groupings of upgrades. > > Before this patch: > upgrade -> upgrade_item(1+) that was a potentially very long list of items. > > After: > upgrade -> upgrade_group(1+) -> upgrade_item(1+) > > This patch makes only one group, a future patch will take in account the > upgrade pack to make the groups. This patch addresses DB and API changes for > this new layout. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 9858e46 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeItemResourceDefinition.java > 9ff5dee > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java > 914e81d > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeGroupService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeItemService.java > 0dde13b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeService.java > cd93bda > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > 83f0e0f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java > fb7789c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 16a8f3c > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > 5564b31 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java > 6df5502 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > 41346d0 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeGroupEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java > 2ae6944 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > a6157fb > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 110abe0 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 9e4cad3 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 92e9170 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > a35d33e > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f553f6e > ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 45b3168 > ambari-server/src/main/resources/META-INF/persistence.xml d0e662c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 046a69b > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java > 4848428 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 5f0b03a > > Diff: https://reviews.apache.org/r/28522/diff/ > > > Testing > ------- > > Tests run: 2307, Failures: 0, Errors: 0, Skipped: 14 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 16:39.050s > [INFO] Finished at: Thu Nov 27 20:53:03 EST 2014 > [INFO] Final Memory: 28M/261M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
