> On Dec. 2, 2014, 4:49 p.m., Nate Cole wrote: > > I agree with Dmitro Lisnichenko. There is the directory > > a-s/src/main/python/ambari_server that these new classes can be moved to. > > That helps a lot to cut down on the cruft in ambari-server.py. > > Dmytro Shkvyra wrote: > Nate, please see main jira "should not show traceback on exception during > setup". There are a lot of other classes (sub tasks) which should be > extracted. I just want to do this step by step to provide more often code > integration. Ends up, all extracted classes can be moved to separate files. > Common, for all changes, patch will be to big and difficult for review. So I > have divided main jira to small subtasks.
Ok. I'll provide common path for all my changes. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28529/#review63546 ----------------------------------------------------------- On Nov. 28, 2014, 6:46 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28529/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2014, 6:46 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, > Nate Cole, and Jeff Sposetti. > > > Bugs: AMBARI-8475 > https://issues.apache.org/jira/browse/AMBARI-8475 > > > Repository: ambari > > > Description > ------- > > Extract HTTPS_Manager and JDK_manager classes from ambari-server.py > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py fc3b843 > ambari-server/src/test/python/TestAmbariServer.py 0eae33b > > Diff: https://reviews.apache.org/r/28529/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >