----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28908/#review64583 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/actionmanager/StageStatus.java <https://reviews.apache.org/r/28908/#comment107349> Can use Enum.setOf(e1, ...) instead of new HashSet() - Nate Cole On Dec. 10, 2014, 1:01 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28908/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 1:01 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-8643 > https://issues.apache.org/jira/browse/AMBARI-8643 > > > Repository: ambari > > > Description > ------- > > Initial checkin of API changes for manually triggered/continuable upgrade > item. > > Note : this is incomplete but intended to unblock UI development by making > the APIs available. Additional backend work and testing is required. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/StageStatus.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java > c25152d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java > 85d2c9a > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/StageStatusTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java > e2d4d9f > > Diff: https://reviews.apache.org/r/28908/diff/ > > > Testing > ------- > > Added unit tests for state transition. Additional unit tests are required. > > All existing unit tests pass. > > Results : > > Tests run: 2402, Failures: 0, Errors: 0, Skipped: 22 > > > Thanks, > > Tom Beerbower > >
