----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28841/#review64647 -----------------------------------------------------------
Ship it! Ship It! - Sid Wagle On Dec. 9, 2014, 8:03 a.m., Szilard Nemethy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28841/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 8:03 a.m.) > > > Review request for Ambari, Dmytro Sen, Mahadev Konar, Myroslav Papirkovskyy, > and Sid Wagle. > > > Bugs: AMBARI-8521 > https://issues.apache.org/jira/browse/AMBARI-8521 > > > Repository: ambari > > > Description > ------- > > Add STORM metric sink implementation to enable sink to AMS > > > Diffs > ----- > > ambari-metrics/ambari-metrics-storm-sink/pom.xml PRE-CREATION > ambari-metrics/ambari-metrics-storm-sink/src/main/assemblies/empty.xml > PRE-CREATION > ambari-metrics/ambari-metrics-storm-sink/src/main/assemblies/sink.xml > PRE-CREATION > > ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2 > PRE-CREATION > > ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java > PRE-CREATION > > ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java > PRE-CREATION > ambari-metrics/pom.xml 12c571b > > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py > 7164ebd > > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/storm.py > bb065da > > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/templates/storm-metrics2.properties.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/templates/storm.yaml.j2 > ffb92e4 > > Diff: https://reviews.apache.org/r/28841/diff/ > > > Testing > ------- > > Unit testing. > Manual testing. > > > Thanks, > > Szilard Nemethy > >
