----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27871/#review64955 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java <https://reviews.apache.org/r/27871/#comment107792> Since the file is being set and not the path, shouldn't the method name be setKerberosFile() ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java <https://reviews.apache.org/r/27871/#comment107793> Can KerberosServiceDesctiptor.fromFile() return null? If not, no need for the if check. ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java <https://reviews.apache.org/r/27871/#comment107795> javadoc ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java <https://reviews.apache.org/r/27871/#comment107796> no need for prefixing method with 'this'. Just use getServices() - John Speidel On Dec. 11, 2014, 2:03 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27871/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 2:03 p.m.) > > > Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert > Nettleton, Tom Beerbower, and Yusaku Sako. > > > Bugs: AMBARI-8247 > https://issues.apache.org/jira/browse/AMBARI-8247 > > > Repository: ambari > > > Description > ------- > > Provide a way for a caller via the REST API to get information about a > service's Kerberos descriptor. This information should probably be attached > to a service resource response. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 60d4f9b > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > 2794c18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java > a338a12 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 1296ba1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java > 8c9a139 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > 843df0b > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > d025946 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java > 1e1e3a0 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > 0fd8728 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 5224aaa > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > b99dcd6 > ambari-server/src/main/resources/properties.json fe67de9 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 734f4b9 > > ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java > b6b7190 > > ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/27871/diff/ > > > Testing > ------- > > Ran all unit tests for ambari-server > Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 40:22 min > [INFO] Finished at: 2014-12-11T13:14:46+00:00 > [INFO] Final Memory: 43M/503M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
