-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29204/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-8789
    https://issues.apache.org/jira/browse/AMBARI-8789


Repository: ambari


Description
-------

1. The currently executing upgrade group goes back and forth from being 
clickable to not clickable. Once upgrade group execution starts, it should 
remain clickable with the "in progress" gear icon shown in blue.
2. Completed upgrade groups should be shown with a green check mark and should 
be clickable. Currently it is non clickable and shown with a gray gear and text.
3. The "in progress" icon should be shown in blue with 3 gears (just as we do 
in the BGO popup). Currently it is shown as a black icon.
4. When the upgrade is paused, do not show the overall progress at 100%. The 
percentage completion should remain as is. Also, the progress bar should stop 
animating.
5. Aborted upgrade groups / items / tasks should be shown in the same way as 
"PENDING" (grayed out and disabled)


Diffs
-----

  ambari-web/app/assets/test/tests.js 8551e9a 
  ambari-web/app/models/upgrade_entity.js 9b546cb 
  ambari-web/app/styles/application.less c3d3d86 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_dialog.hbs 
3b09640 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
PRE-CREATION 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_group.hbs f94ff98 
  ambari-web/app/utils/helper.js 899b9a0 
  ambari-web/app/views.js cf384d9 
  ambari-web/app/views/common/progress_bar_view.js PRE-CREATION 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_group_view.js 11bf0f2 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js 377287b 
  ambari-web/test/models/upgrade_entity_test.js PRE-CREATION 
  ambari-web/test/views/common/progress_bar_view_test.js PRE-CREATION 
  ambari-web/test/views/main/admin/stack_upgrade/upgrade_group_view_test.js 
0cabbd2 
  ambari-web/test/views/main/admin/stack_upgrade/upgrade_task_view_test.js 
PRE-CREATION 
  ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js 
PRE-CREATION 

Diff: https://reviews.apache.org/r/29204/diff/


Testing
-------

5268 tests complete (8 seconds)
  60 tests pending


Thanks,

Andrii Tkach

Reply via email to