> On Dec. 18, 2014, 8:10 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java,
> > line 1387
> > <https://reviews.apache.org/r/29189/diff/2/?file=795596#file795596line1387>
> >
> > This change will break a per-host reinstallation scenario. In this
> > case, cluster transitions from INSTALLED to INSTALLED state on success
> > command report from host.
> > Alternatively, you may call
> > org.apache.ambari.server.state.Cluster#recalculateClusterVersionState at
> > org.apache.ambari.server.controller.internal.HostStackVersionResourceProvider#createResources
> > (the idea is to transition cluster to INSTALLING state even during a
> > single host reinstallation)
Because this is purely a DB operation, we shouldn't need to process logic in
the case of a no-op; so it should be taken care of by,
"if (existingClusterVersion.getState() != state) {"
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29189/#review65533
-----------------------------------------------------------
On Dec. 18, 2014, 4:18 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29189/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 4:18 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole,
> Tom Beerbower, and Yurii Shylov.
>
>
> Bugs: AMBARI-8778
> https://issues.apache.org/jira/browse/AMBARI-8778
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Upgrade Pack needs a group for Cluster Post-Upgrade that will have 2
> steps,
> 1. Custom Action to send the hdfs finalize command to the agent
> 2. Server Action to complete the upgrade by setting all of the host_versions
> and the cluster_version from upgraded/upgrading -> current.
> The Finalize can only happen once all hosts have been upgraded.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
> 71bb22c
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
> b450eeb
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> a90fcc7
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
> da784c3
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServerActionTask.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java
> 0c4d363
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java
> c1e65ca
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
> b86aa45
>
> Diff: https://reviews.apache.org/r/29189/diff/
>
>
> Testing
> -------
>
> Verfied this worked on a 1-node cluster.
> First, had to comment out the Core Masters and Core Slaves groups in
> upgrade-2.2.xml since both of those require HA and manual steps to be
> working, which are not ready yet.
> Then, distributed a repository version, and ran the upgrade pack.
>
> ABO Unit tests failed in an unrelated class. I then reran just that class
> manually and it passed.
>
>
> Tests in error:
>
> test220Cardinality(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
> Unable to parse stack upgrade file at location:
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
>
> test220AutoDeploy(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
> Unable to parse stack upgrade file at location:
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
>
> test220Dependencies(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
> Unable to parse stack upgrade file at location:
> /home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
>
> Tests run: 2437, Failures: 0, Errors: 3, Skipped: 13
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 38:13 min
> [INFO] Finished at: 2014-12-18T03:49:05+00:00
> [INFO] Final Memory: 24M/214M
> [INFO]
> ------------------------------------------------------------------------
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
