-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29518/
-----------------------------------------------------------

(Updated Dec. 31, 2014, 7:50 p.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-8969
    https://issues.apache.org/jira/browse/AMBARI-8969


Repository: ambari


Description
-------

Each event/occurrence of an alert should send out an SNMP trap to the 
configured SNMP trapd (typically a network management system - 
netcool/openview/unicenter etc.).

There is also a change to several of the JSON alerts files to make the reported 
TCP time match that of the port alert (it's been bothering me, so I just 
included it in this one).


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/notifications/NotificationDispatcher.java
 10946be 
  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/EmailDispatcher.java
 f979c03 
  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java
 0e75801 
  
ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java
 b085112 
  ambari-server/src/main/resources/alert-templates.xml c00e9d8 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/alerts.json 
c34093f 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
8de4b3a 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json 
970c9d4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/alerts.json 
4800fcb 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json 
091377f 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json 
690ca03 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/alerts.json 
cd54607 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/alerts.json 
d536647 
  
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/alerts.json
 f192e2c 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/alerts.json 
df8ab0f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json 
32dc474 
  
ambari-server/src/test/java/org/apache/ambari/server/notifications/EmailDispatcherTest.java
 1e7689f 
  
ambari-server/src/test/java/org/apache/ambari/server/notifications/MockDispatcher.java
 616551f 
  
ambari-server/src/test/java/org/apache/ambari/server/state/services/AlertNoticeDispatchServiceTest.java
 2e984bf 

Diff: https://reviews.apache.org/r/29518/diff/


Testing (updated)
-------

mvn clean test & manual tests for both EMAIL and SNMP.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:03 min
[INFO] Finished at: 2014-12-31T17:20:01-05:00
[INFO] Final Memory: 36M/463M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley

Reply via email to