> On Янв. 5, 2015, 7:58 п.п., Nate Cole wrote: > > Are there any new testing changes to go with this?
I've added test for general method used to call all checks. As for particular repository_version check, it doesn't have a unit test at all, this issue is added to technical debt ticket - Yurii ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29587/#review66708 ----------------------------------------------------------- On Янв. 7, 2015, 4:25 п.п., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29587/ > ----------------------------------------------------------- > > (Updated Янв. 7, 2015, 4:25 п.п.) > > > Review request for Ambari, Dmitro Lisnichenko and Nate Cole. > > > Bugs: AMBARI-8991 > https://issues.apache.org/jira/browse/AMBARI-8991 > > > Repository: ambari > > > Description > ------- > > The following requests: > /api/v1/clusters/1/rolling_upgrades_check/?fields=UpgradeChecks/repository_version > /api/v1/clusters/1/rolling_upgrades_check/?UpgradeChecks/repository_version=2.99999&fields=* > /api/v1/clusters/sdfdsfdsfdsf1/rolling_upgrades_check/?UpgradeChecks/repository_version=2.99999&fields=* > are generating error with "reason" : "Unexpected server error happened". > > These usecases should be checked explicitely > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java > 355532f > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeCheckHelperTest.java > 2cbe088 > > Diff: https://reviews.apache.org/r/29587/diff/ > > > Testing > ------- > > Tests ok > > > Thanks, > > Yurii Shylov > >
