----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29693/ -----------------------------------------------------------
Review request for Ambari, John Speidel and Robert Levas. Repository: ambari Description ------- This patch fixes AMBARI-9036. Blueprints that included Storm, but not Ganglia, were failing due to an issue in the BlueprintConfigurationProcessor. The BlueprintConfigurationProcessor was failing during an attempt to perform hostname substitution on some storm-site properties. These properties are mapped to the GANGLIA_SERVER's hostname. If GANGLIA_SERVER is not included in the cluster, the Blueprint deployment will fail. This patch addresses this issue by: - Creating a new property updater, OptionalSingleHostTopologyUpdater, that extends the SingleHostTopologyUpdater. The extended class allows a specified component to be considered optional. In the event that a component is not available, this updater will return the original property value. - Creates new unit tests to verify this change. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 807723e ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 3796bbb Diff: https://reviews.apache.org/r/29693/diff/ Testing ------- 1. Ran the ambari-server unit test suite: "Results : Tests run: 2490, Failures: 0, Errors: 0, Skipped: 13" 2. Manually tested a Blueprint deployment (including Storm, excluding Ganglia) with my patch applied. Thanks, Robert Nettleton
