> On Jan. 13, 2015, 8:07 a.m., Jayush Luniya wrote: > > ambari-common/src/main/python/ambari_commons/os_utils.py, line 32 > > <https://reviews.apache.org/r/29779/diff/1/?file=814947#file814947line32> > > > > Remove comment?
Comment from long time ago - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29779/#review67817 ----------------------------------------------------------- On Jan. 9, 2015, 9:58 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29779/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 9:58 p.m.) > > > Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan > Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole. > > > Bugs: AMBARI-8317 > https://issues.apache.org/jira/browse/AMBARI-8317 > > > Repository: ambari > > > Description > ------- > > +Fixed ambari_server import in TestAmbariServer.py, to allow future imports > from modules in the ambari_server subdir > +Moved SILENT, VERBOSE and DEBUG_MODE to logging_utils.py, to allow future > use from modular code > +Moved run_os_command to os_utils > +Extended the set of test platform primitives > +Optimized imports > > > Diffs > ----- > > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py > 338d080d02b294788d393d415bbf08a155acd392 > ambari-agent/src/test/python/ambari_agent/TestRegistration.py > 41f98805b92df68296e3b0494f9fc7de6db1b0b0 > ambari-common/src/main/python/ambari_commons/firewall.py > b73cc0cc15cb441b35c0db7ed449ee8f2440134f > ambari-common/src/main/python/ambari_commons/logging_utils.py > 9d45fdb73d8ab93c84930b059750e8e02fb5cf7e > ambari-common/src/main/python/ambari_commons/os_linux.py > 38f3fb9999d19056cca471ad7de64a4b62cb9723 > ambari-common/src/main/python/ambari_commons/os_utils.py > 942a920abf183950e54ebe83fcce92c178f61b70 > ambari-common/src/main/python/ambari_commons/os_windows.py > 7918a2f52fdfb70f4ab5de1a2073da8bec132346 > > ambari-common/src/main/python/resource_management/core/providers/windows/system.py > e7a98fc432003b7b818671b8c7fdcfc498f3ad84 > > ambari-common/src/main/python/resource_management/libraries/functions/get_unique_id_and_date.py > afc82bb4905c806a16a6b67831fdf2fc02ed0875 > ambari-common/src/test/python/only_for_platform.py > a0b544225964e6e912fa5b56e9e566c092230dc2 > ambari-server/conf/windows/ambari.properties > 3982bb9d6ccde94e7548b121bb4cfff5fabd3977 > ambari-server/src/main/python/ambari-server-windows.py > 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f > ambari-server/src/main/python/ambari-server.py > af27f5f3be7bf15597fb4545fcd7e393096ca4a7 > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py > ce47faec7023050adc451d6df5c9f6cac64ec9be > ambari-server/src/main/python/ambari_server/serverConfiguration.py > 5e5c440d9971a87cac21ce7ff57f2d29a240b781 > ambari-server/src/main/python/ambari_server/serverSetup.py > 2b9c950221d84d5d44ed73e8e4a1d757388f1937 > ambari-server/src/main/python/ambari_server/serverSetup_linux.py > b5436e0c1263e52b1ac9b33a24f02e969c72cd70 > ambari-server/src/main/python/ambari_server/serverSetup_windows.py > a906ef50020e4eb0b9608bf8c1f43681029699ff > ambari-server/src/main/python/ambari_server/setupSecurity.py > 57a323103d23f3d05450a94d9875694001544337 > ambari-server/src/main/python/ambari_server/userInput.py > 7a35831d0f24889b5dd29da2445c877d0d1844ca > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 3221cdb089b8b73932529a2aac1079c16045a4db > ambari-server/src/test/python/TestAmbariServer.py > 5f1fa388ff551222a534f4af1c00b34c070ec5fc > ambari-server/src/test/python/custom_actions/TestCheckHost.py > f910d067458efec9b85c7ad6a05e4bce696fb522 > ambari-server/src/test/python/unitTests.py > e812b831d625235549a3748f0068f651e7345679 > > Diff: https://reviews.apache.org/r/29779/diff/ > > > Testing > ------- > > mvn clean test > ambari-server setup on Linux & WIndows > > > Thanks, > > Florian Barca > >
