----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29863/#review68046 -----------------------------------------------------------
Ship it! Looks good. - Tom Beerbower On Jan. 14, 2015, 2:20 p.m., Jeff Sposetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29863/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 2:20 p.m.) > > > Review request for Ambari, Tom Beerbower and Yusaku Sako. > > > Bugs: AMBARI-9111 > https://issues.apache.org/jira/browse/AMBARI-9111 > > > Repository: ambari > > > Description > ------- > > Various UI cleanup for Capacity Scheduler view: > - Added range control for setting queue capacity/max > - Added ability to show/hide peer queues > - Added support for optional queue properties > - Added instructions for working with vagrant and local build > - Remove show/edit controls > - Convert max AM to percent, not decimal, in UI > - Added support for App.testMode=true for UI dev > - Added support for label and placeholder text on instance config properties > - Up'd version to 0.3.0 > - Small text cleanup in tez view readme.md and property-validator-view > index.md > > > Diffs > ----- > > ambari-views/examples/property-validator-view/docs/index.md ae00c06 > contrib/views/capacity-scheduler/cs-view.jpg PRE-CREATION > contrib/views/capacity-scheduler/pom.xml 7b0eb41 > contrib/views/capacity-scheduler/readme.md 6428d21 > contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js > cee4ac1 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/data/capacity-scheduler.json > bee7fa2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/data/privilege.json > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/data/scheduler-configuration.json > bee7fa2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > b46933a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/totalCapacity.js > 5e35b30 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js > a0db1f1 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js > cc20706 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 3219660 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 8f394b8 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capacityEditForm.hbs > 51e2bb4 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/capacityBar.hbs > d860cc4 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/totalCapacity.hbs > e00c1cc > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/userGroupInput.hbs > fab7ea8 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs > caf3dd1 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queues.hbs > 2c00541 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/schedulerPanel.hbs > 7333006 > contrib/views/capacity-scheduler/src/main/resources/ui/config.coffee > 2fe3325 > contrib/views/capacity-scheduler/src/main/resources/view.xml 6206ccc > contrib/views/tez/readme.md 68e3994 > > Diff: https://reviews.apache.org/r/29863/diff/ > > > Testing > ------- > > > Thanks, > > Jeff Sposetti > >
