-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29544/
-----------------------------------------------------------
(Updated Янв. 14, 2015, 4:46 п.п.)
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-8973
https://issues.apache.org/jira/browse/AMBARI-8973
Repository: ambari
Description
-------
Modify AMS API layer to switch precision level based on query window.
E.g.: Any query > 1 hour should get data from the 5 minute aggregate table
unless user provides a precision parameter.
-startTime - endTime = 1 day OR precision = minutes
implies query => 5 minute table
-startTime - endTime = 3 hours and precision = seconds
implies query => minute table (METRIC_RECORD)
So, effectively we are just using the precision as guidance paramete
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
3238312
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
8be5112
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java
421d533
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/Precision.java
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricAggregator.java
f4f895f
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregator.java
e291f36
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricClusterAggregatorHourly.java
1d5c5a4
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
5224450
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
c9d56fc
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
2ca7669
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITClusterAggregator.java
2da9c82
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITMetricAggregator.java
22e1363
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricTestHelper.java
PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java
0722ccd
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java
333b13b
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
c893314
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestTimelineWebServices.java
2b93190
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
bf68986
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
e9aac45
Diff: https://reviews.apache.org/r/29544/diff/
Testing
-------
[INFO] ambari-metrics .................................... SUCCESS [0.507s]
[INFO] ambari-metrics-common ............................. SUCCESS [2.391s]
[INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.805s]
[INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.456s]
[INFO] ambari-metrics-storm-sink ......................... SUCCESS [0.948s]
[INFO] ambari-metrics-timelineservice .................... SUCCESS [3:33.874s]
[INFO] ambari-metrics-host-monitoring .................... SUCCESS [3.471s]
[INFO] ambari-metrics-assembly ........................... SUCCESS [0.142s]
Thanks,
Dmytro Sen
