----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29956/#review68405 -----------------------------------------------------------
Interesting, this will do service checks first for the priority, then for the remaining services. If the "service_check" bool is set to false, then it uses the new logic? Otherwise, it only runs service checks for the items in that group? - Alejandro Fernandez On Jan. 16, 2015, 2:52 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29956/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 2:52 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom > Beerbower. > > > Bugs: AMBARI-9167 > https://issues.apache.org/jira/browse/AMBARI-9167 > > > Repository: ambari > > > Description > ------- > > Enable full smoke tests. Involved changes to the upgrade pack: > > Each group runs it's own service check. Need to be able to turn them off > such that the next group (a service-check one) that runs full checks doesn't > re-run ones it just did. For example. Full service checks happen after each > of CORE_MASTER, CORE_SLAVE, and CLIENT. No need to run service checks on > CORE_MASTER when running them all right after anyway. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > cdecac6 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java > 1b957da > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > b4a75ae > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > 15aa1f5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 26e1546 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > cf2de93 > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/29956/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:47.403s > [INFO] Finished at: Thu Jan 15 21:44:24 EST 2015 > [INFO] Final Memory: 31M/337M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
