[ 
https://issues.apache.org/jira/browse/AMBARI-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282580#comment-14282580
 ] 

Hadoop QA commented on AMBARI-9194:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12693094/AMBARI-9194.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/1384//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/1384//console

This message is automatically generated.

> Description for Finalize needs to be more specific. Finalize action needs to 
> have a confirmation.
> -------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-9194
>                 URL: https://issues.apache.org/jira/browse/AMBARI-9194
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-web
>    Affects Versions: 2.0.0
>            Reporter: Andrii Tkach
>            Assignee: Andrii Tkach
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: AMBARI-9194.patch
>
>
> Currently, it just says "Please confirm you are ready to finalize."
> This sounds too light. Let's let the user know that there's no going back 
> once it is finalized, and the user is encouraged to run tests on the cluster 
> before finalizing.
> Make the changes on the UI side, as this is going to be a UI-specific message 
> and handling.
> 1) Change message:
> "Your cluster version has been upgraded. Click on *Finalize* when you are 
> ready to finalize the upgrade and commit to the new version. You are strongly 
> encouraged to run tests on your cluster to ensure it is fully operational 
> before finalizing. *You cannot go back to the original version once the 
> upgrade is finalized.*" 
> 2)  Safe guard the "Finalize" button with a Confirmation popup:  
> You are about to finalize the upgrade. *You cannot go back to the original 
> version once the upgrade is finalized.* Proceed with finalizing?
> Cancel / Finalize
> 3) Have 3 buttons: Downgrade (red) / Finalize Later (gray) / Finalize 
> (green).  Clicking on Finalize Later simply dismisses the popup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to