----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30045/#review68718 -----------------------------------------------------------
Ship it! Looks good. - Tom Beerbower On Jan. 19, 2015, 6:41 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30045/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 6:41 p.m.) > > > Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower. > > > Bugs: AMBARI-9203 > https://issues.apache.org/jira/browse/AMBARI-9203 > > > Repository: ambari > > > Description > ------- > > Add new API for base url validations: > {code} > POST > http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/operating_systems/redhat6/repositories/?validate_only=true > { > "Repositories": { > "repo_id":"HDP-2.2", > > "base_url":"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/GA/2.2.0.0"; > } > } > {code} > or > {code} > POST > http://c6401.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.2/operating_systems/redhat6/repositories/HDP-2.2?validate_only=true > { > "Repositories": { > > "base_url":"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/GA/2.2.0.0"; > } > } > {code} > or > {code} > [ > { > "Repositories": { > "repo_id":"HDP-2.2", > > "base_url":"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/GA/2.2.0.0"; > } > }, > { > "Repositories": { > "repo_id":"HDP-2.2", > > "base_url":"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/GA/2.2.0.0"; > } > } > ] > {code} > > should result in 2xx status response *without* creating a new resource if > base url is valid or 5xx status if invalid. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryResourceDefinition.java > 85ac5bb > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryService.java > 166f700 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > 610625a > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 6dabcbb > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java > 853623f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java > 8c0a46c > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryServiceTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > a6d322d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > aef5541 > > Diff: https://reviews.apache.org/r/30045/diff/ > > > Testing > ------- > > In progress > > > Thanks, > > Yurii Shylov > >
