----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30215/#review69401 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Jan. 23, 2015, 11:37 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30215/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 11:37 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-9301 > https://issues.apache.org/jira/browse/AMBARI-9301 > > > Repository: ambari > > > Description > ------- > > While you change view info via Edit button, the changes do not show after > save. > > STR: > 1. Create new view > 2. Go to Views and select it > 3. Click Edit and edit Display Name and Description > 4. Click Save > > ER: View info will changed > AR: No changes in the view info > > Registry copy of view instance entity gets out of sync with persisted > instance entity. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > e422a46 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > 14dd4cf > > Diff: https://reviews.apache.org/r/30215/diff/ > > > Testing > ------- > > Manual testing. > > Update view instance unit test updated to cover this case. > > All tests pass ... > > Tests run: 2576, Failures: 0, Errors: 0, Skipped: 15 > > > Thanks, > > Tom Beerbower > >
