> On Jan. 27, 2015, 8:33 a.m., Jayush Luniya wrote: > > ambari-server/src/main/python/setupAgent.py, line 32 > > <https://reviews.apache.org/r/30307/diff/1/?file=836154#file836154line32> > > > > Change to OSCheck import doesnt seem to be required.
The issue is a bit more cumbersome than it seems. Ironically, the production code is more relaxed due to the existence of the "all" clause in __init__. The test code will have issues though, because of the way the mocks work, which require the imports' syntax to be normalized, one way or the other. So, this file is ok, but expect changes in the test scripts. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30307/#review69764 ----------------------------------------------------------- On Jan. 27, 2015, 4:15 a.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30307/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 4:15 a.m.) > > > Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene > Chekanskiy, Jayush Luniya, Mahadev Konar, and Yusaku Sako. > > > Bugs: AMBARI-9341 > https://issues.apache.org/jira/browse/AMBARI-9341 > > > Repository: ambari > > > Description > ------- > > +Fixed the ambari_commons imports to only include the bare minimum required > to function > +Fixed the incompartibilities with Python 2.4 > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/__init__.py > df4d7d68e6efcb9e8aeede1e43f060b76b46b204 > ambari-server/src/main/python/bootstrap.py > 8ac6a370e5b84400ab04fa7614da88d5e6941566 > ambari-server/src/main/python/setupAgent.py > 8f9c48f03f545227e88042c03a3ee19a1651a67e > > Diff: https://reviews.apache.org/r/30307/diff/ > > > Testing > ------- > > mvn clean test > manual simulation of the agent registration process, due to the absence of a > fake yum repository -> scripts run ok > > > Thanks, > > Florian Barca > >
