----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30451/#review70364 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/30451/#comment115479> I actually don't see a problem with creating a new configuration when hive server is moved, but apparently someone did since the bug was filed. With that said, comparing configurations for equality between a request and an existing configuration type is something that could probably go in ConfigHelper to be reused in other areas of the application. Can we move this to a central location? ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/30451/#comment115478> You can short circuit the loop at this point by just checking to see if requestConfigProperties is null; no reason to do any extra work like getting the clusterConfig if there's nothing in the request. - Jonathan Hurley On Jan. 30, 2015, 9:22 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30451/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 9:22 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-9414 > https://issues.apache.org/jira/browse/AMBARI-9414 > > > Repository: ambari > > > Description > ------- > > After adding, deleting or moving HiveServer2 new Hive configs version is > created, but it contains no difference with the previous one. > The same occurs for core-site configs. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > e867f99 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > e2ae6d6 > > Diff: https://reviews.apache.org/r/30451/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
