-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30488/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-9420
https://issues.apache.org/jira/browse/AMBARI-9420
Repository: ambari
Description
-------
Consider the issue described in BUG-30470, where Hive's configure task has
different behavior based on an aspect of the system. As a result, the configure
task should allow additional elements/attributes that govern what to change and
when.
An example of this might be
```
<task xsi:type="configure">
<condition>
<property>hive.server2.transport.mode<property/>
<value>http</value>
<type>hive-site</type>
<key>hive.server2.http.port</key>
<value>10011</value>
<condition>
<condition>
<property>hive.server2.transport.mode<property/>
<value>binary</value>
<type>hive-site</type>
<key>hive.server2.thrift.port</key>
<value>10010</value>
<condition>
</task>
```
Additionally, there can be more specific configure tasks as well. Such as a
port configuration task which knows to adjust the port by 10 beyond the current
value.
Existing configure tasks in the upgrade XML should be evaluated to determine
what the requirements are to allow for a more flexible upgrade script.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
2af90f6
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
549f9fa
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
f215e6d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
6388bc9
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
686cc6e
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml
37f8cc0
Diff: https://reviews.apache.org/r/30488/diff/
Testing
-------
Performed an upgrade to verify that the configure task works correctly; new
test case added to cover conditional functionality.
mvn clean test
Thanks,
Jonathan Hurley
