> On Feb. 3, 2015, 1:42 p.m., Jonathan Hurley wrote: > > Ship It!
The only issue was the on Nate pointed out with Hive; it should go back into HIVE and I think we still need the 2 different manual tasks. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30569/#review70789 ----------------------------------------------------------- On Feb. 3, 2015, 1:19 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30569/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 1:19 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-9456 > https://issues.apache.org/jira/browse/AMBARI-9456 > > > Repository: ambari > > > Description > ------- > > There should be an explicit stage at the beginning of Rolling Upgrade called > 'Prepare Backups' that does pre-upgrade steps for the following : > > - HBase > - HDFS > - Hive > - Oozie > > As part of this task, we need to ensure that backups steps are removed from > other stages (so that they are not duplicated). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 0d250d3 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > 28d0b1f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 00ba387 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > d878fee > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > cc8bd0a > > Diff: https://reviews.apache.org/r/30569/diff/ > > > Testing > ------- > > Manual testing. > > Unit tests updated. > > All tests pass. > > > Thanks, > > Tom Beerbower > >