> On Feb. 5, 2015, 8:30 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java, > > line 302 > > <https://reviews.apache.org/r/30641/diff/1/?file=848997#file848997line302> > > > > Null check required if placing into a hashed collection before being > > persisted. Just return 0. > > Nate Cole wrote: > taskId is a primitive long and initialized, so how would a null check help
That's what I get for looking at reviews when I'm sick. Nervermind. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30641/#review71204 ----------------------------------------------------------- On Feb. 4, 2015, 5:34 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30641/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 5:34 p.m.) > > > Review request for Ambari, Jonathan Hurley and Tom Beerbower. > > > Bugs: AMBARI-9481 > https://issues.apache.org/jira/browse/AMBARI-9481 > > > Repository: ambari > > > Description > ------- > > * Fixed HostRoleCommand to return a better hashCode(), equals() as the old > implementations did not consider that two tasks would have the same member > values > * Added computation for groups > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > 59fce90 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java > 24a4589 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > 28e0d17 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java > c89d005 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java > ca1e583 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 00ba387 > > Diff: https://reviews.apache.org/r/30641/diff/ > > > Testing > ------- > > Tests run: 2642, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:54.495s > [INFO] Finished at: Wed Feb 04 17:21:08 EST 2015 > [INFO] Final Memory: 32M/368M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
