> On Feb. 20, 2015, 9:37 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java, > > line 502 > > <https://reviews.apache.org/r/31208/diff/1/?file=869712#file869712line502> > > > > Could there ever be a case where "smokeuser" isn't in the map either?
I beleive that more will break if `smokeuser` is not set. Most, if not all, of the service checks rely on it. However if it is not set, the code gets around this gracefully (if inserting `null` into a property value is acceptable), but I am not sure what value should be used. Any suggestions? - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31208/#review73277 ----------------------------------------------------------- On Feb. 20, 2015, 6:11 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31208/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 6:11 a.m.) > > > Review request for Ambari, Andrew Onischuk, Ivan Kozlov, Mahadev Konar, Nate > Cole, and Robert Nettleton. > > > Bugs: AMBARI-9702 > https://issues.apache.org/jira/browse/AMBARI-9702 > > > Repository: ambari > > > Description > ------- > > ``` > 2015-02-13 11:32:12,437 - Error while executing command 'start': > Traceback (most recent call last): > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 184, in execute > method(env) > File > "/var/lib/ambari-agent/cache/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py", > line 78, in start > zookeeper_service(action = 'start') > File > "/var/lib/ambari-agent/cache/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py", > line 38, in zookeeper_service > kinit_cmd = format("{kinit_path_local} -kt {smoke_user_keytab} > {smokeuser_principal};") > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py", > line 83, in format > return ConfigurationFormatter().format(format_string, args, **result) > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py", > line 47, in format > result_protected = self.vformat(format_string, args, all_params) > File "/usr/lib64/python2.6/string.py", line 549, in vformat > result = self._vformat(format_string, args, kwargs, used_args, 2) > File "/usr/lib64/python2.6/string.py", line 582, in _vformat > result.append(self.format_field(obj, format_spec)) > File "/usr/lib64/python2.6/string.py", line 599, in format_field > return format(value, format_spec) > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py", > line 79, in __getattr__ > raise Fail("Configuration parameter '"+self.name+"' was not found in > configurations dictionary!") > Fail: Configuration parameter 'smokeuser_principal_name' was not found in > configurations dictionary! > ``` > > This is caused due to missing `cluster-env/smokeuser_principal_name` value. > It needs to be created using the upgrade process using the value from > `cluster-env/smokeuser` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 71049b2 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > f5dbd38 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 1d4713a > > Diff: https://reviews.apache.org/r/31208/diff/ > > > Testing > ------- > > Manualy tested in cluster > > #Jenkins test results: > > Running org.apache.ambari.server.upgrade.UpgradeCatalog200Test > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.937 sec > > Ambari server test suite > Tests run: 2722, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:11 h > [INFO] Finished at: 2015-02-19T22:09:08+00:00 > [INFO] Final Memory: 44M/514M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
