-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31351/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 11:57 a.m.)
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-9766
https://issues.apache.org/jira/browse/AMBARI-9766
Repository: ambari
Description
-------
When loading a stack, any failure in format or XML files can cause an
exception. When this occurs, no other definition gets loaded. A failure should
not fail EVERY stack, just skip the bad one. Or, provide an "isValid()"
method/message on the stack object to indicate what is wrong with that
definition.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java
a8ab755
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java
ddb9301
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
4205da8
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
d4c99e5
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationInfo.java
97d57cb
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java
fde7b2d
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
c502244
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java
a30d761
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionModule.java
f938ba8
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
b5930b2
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java
e55120e
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java
ce2ff2d
ambari-server/src/main/java/org/apache/ambari/server/stack/Validable.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java
d469c17
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java
c1c483f
ambari-server/src/main/java/org/apache/ambari/server/state/stack/ConfigurationXml.java
50ab901
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
fa5607b
ambari-server/src/main/java/org/apache/ambari/server/state/stack/ServiceMetainfoXml.java
4d3587e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackMetainfoXml.java
cd02f45
ambari-server/src/main/resources/properties.json cd50968
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
7b0d80c
Diff: https://reviews.apache.org/r/31351/diff/
Testing (updated)
-------
Unit test failure is unrelated
Tests in error:
org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderForDNWithSpaceTest:
/tmp/server-work-Test/log/revision (No such file or directory)
Tests run: 2741, Failures: 0, Errors: 1, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.959s]
[INFO] Ambari Server ..................................... FAILURE [31:26.538s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:33.168s
[INFO] Finished at: Tue Feb 24 14:47:51 FET 2015
[INFO] Final Memory: 30M/210M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
