[
https://issues.apache.org/jira/browse/AMBARI-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337813#comment-14337813
]
Hadoop QA commented on AMBARI-9805:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12700948/AMBARI-9805.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/1819//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/1819//console
This message is automatically generated.
> RU - Bug fixes for Host Version transition and Finalize
> -------------------------------------------------------
>
> Key: AMBARI-9805
> URL: https://issues.apache.org/jira/browse/AMBARI-9805
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.0.0
> Reporter: Alejandro Fernandez
> Assignee: Alejandro Fernandez
> Labels: rolling_upgrade
> Fix For: 2.0.0
>
> Attachments: AMBARI-9805.patch
>
>
> 1. There is a bug in ServiceComponentHostSummary.java since its constructor
> should not be comparing against the string UKNOWN, but rather rely on
> ComponentInfo to determine which components need to advertise a version.
> Also, the function haveAllComponentsFinishedAdvertisingVersion should instead
> compare the size of all components that can advertise a version, and the
> subset of those that have done so already.
> 2. ClusterImpl.java has a bug in transitionHostVersionState() when setting
> the state to UPGRADING if the Host has exactly one Component with a version.
> 3. FinalizeUpgradeAction.java has redundant code now that AMBARI-9755 is in
> because the call to transitionClusterVersion() will also take care of
> transitioning HostVersions from INSTALLED->CURRENT for hosts that only have
> components that do not advertise a version.
> It is of the utmost importance to test these changes in the following
> scenarios:
> Host added during cluster install
> Host added after cluster install
> Host added after bits are distributed
> A Host may be added with either 0 services, only services that do not
> advertise a version, or at least one service that advertises a version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
