----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31582/#review74732 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Feb. 28, 2015, 11:39 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31582/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2015, 11:39 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-9848 > https://issues.apache.org/jira/browse/AMBARI-9848 > > > Repository: ambari > > > Description > ------- > > Alerts for services that support a standard HA mode (nameservice and/or > alias) need to be able to understand how to calculate the correct server to > contact. This means building a dynamic key to use when discovering the URL to > use for METRIC and WEB alerts. > > The proposal is to add a new child element to the URL parameter: > > {code} > "high_availability": { > "nameservice": "{{hdfs-site/dfs.nameservices}}", > "alias_key" : "{{hdfs-site/dfs.ha.namenodes.{{ha-nameservice}}}}", > "http_pattern" : > "{{hdfs-site/dfs.namenode.http-address.{{ha-nameservice}}.{{alias}}}}", > "https_pattern" : > "{{hdfs-site/dfs.namenode.https-address.{{ha-nameservice}}.{{alias}}}}" > {code} > > *** NameNode Process was removed because it was a redundant check already > covered by the web client check *** > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 34aeff6 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py ed95dc4 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java > fe592a8 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json > 2910f8b > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json > d51f0d8 > > Diff: https://reviews.apache.org/r/31582/diff/ > > > Testing > ------- > > Deployed a cluster to ensure that existing alerts did not break. Upgraded to > HDFS HA mode and then took down each NN one at a time to verify correct > alerts triggered. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 9.942 s > [INFO] Finished at: 2015-02-28T11:33:54-05:00 > [INFO] Final Memory: 8M/81M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
