----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31709/#review75079 -----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/main.py <https://reviews.apache.org/r/31709/#comment122014> This would mean agent pid is not avaialble in the pid file until connection to the server is successful. Not sure if this would have other side effects, like "ambari-agent stop" will not work, if server is unreachable. - Sid Wagle On March 3, 2015, 11 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31709/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 11 p.m.) > > > Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Mahadev Konar, > and Sid Wagle. > > > Bugs: AMBARI-9913 > https://issues.apache.org/jira/browse/AMBARI-9913 > > > Repository: ambari > > > Description > ------- > > Saving the PID only on successful start > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/main.py > 33c1bc8dcd23ab98c305dff351549824dba4007b > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/main.py > ce8ffc64dbe3717916efe72e8548bd18c93fad18 > > Diff: https://reviews.apache.org/r/31709/diff/ > > > Testing > ------- > > mvn clean test > deployment on a local VM cluster -> register hosts -> backtrack -> register > hosts -> no repro > > > Thanks, > > Florian Barca > >
