----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31877/#review75844 -----------------------------------------------------------
ambari-web/app/templates/main/service/info/configs/yarn_theme.json <https://reviews.apache.org/r/31877/#comment123162> The structure now is: - Theme -- configuration --- layouts --- placement --- widgets ambari-web/app/templates/main/service/info/configs/yarn_theme.json <https://reviews.apache.org/r/31877/#comment123161> We need an extra field called "display-name" also to allow for internationalization later. "display-name" and "name" could be provided for tabs and sections and sub-sections. ambari-web/app/templates/main/service/info/configs/yarn_theme.json <https://reviews.apache.org/r/31877/#comment123163> We currently have only 1 placement, so better to revert this back to 'placement'. ambari-web/app/templates/main/service/info/configs/yarn_theme.json <https://reviews.apache.org/r/31877/#comment123164> subsection-id not required inside widgets. - Srimanth Gunturi On March 10, 2015, 1:38 a.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31877/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 1:38 a.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-9991 > https://issues.apache.org/jira/browse/AMBARI-9991 > > > Repository: ambari > > > Description > ------- > > Create mock YARN theme for UI development > > > Diffs > ----- > > ambari-web/app/templates/main/service/info/configs/yarn_theme.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/31877/diff/ > > > Testing > ------- > > Manually tested on live cluster. No unit test applicable. > > > Thanks, > > Richard Zang > >
