> On March 10, 2015, 2:16 p.m., Andrew Onischuk wrote: > > Just imaged scenario, when after upgrade no tasks where done, and > > before-ANY haven't been called. In that case your alert will fail because > > of absent directory
I flagged this as well. The alert could create the directory if it doesn't exist as part of the constructor. Or, we could just have the alert handler do this as well. Either way, it doesn't need to be in the hooks. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31898/#review75916 ----------------------------------------------------------- On March 10, 2015, 1:40 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31898/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 1:40 p.m.) > > > Review request for Ambari, Andrew Onischuk and Jonathan Hurley. > > > Bugs: AMBARI-10009 > https://issues.apache.org/jira/browse/AMBARI-10009 > > > Repository: ambari > > > Description > ------- > > After enabling security alerts appeared for Yarn and Storm. See attached > files for details. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py d7a833e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py > c90a55c > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > 7f85428 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > b6d2ba2 > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py > f606130 > > Diff: https://reviews.apache.org/r/31898/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
