> On March 25, 2015, 6:43 p.m., Alejandro Fernandez wrote:
> > Ship It!
>
> Alejandro Fernandez wrote:
> Please update the review with the branch (trunk), bug (AMBARI-#####), and
> unit test results.
Actually, would you mind changing the "id" columns back to "{table}_id". I also
used the "id" columns for some schema changes I made, and after talking with
Nate, decided to switch back to "{table}_id" for the sake of consistency. This
work can go in another patch if you'd like.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/#review77774
-----------------------------------------------------------
On March 25, 2015, 5:15 p.m., Ivan Kozlov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32312/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 5:15 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sid Wagle.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apart from adding new widget related table definitions in the DDL script for
> all the three database types, also update the upgrade catalog for
> Amabri-2.1.0 to create these tables on ambari upgrade.
> Tasks:
> Create WidgetEntity and WidgetLayoutEntity.
> Add relationship from both entities to cluster. This will not be used to load
> widgets but only to find what StackVersion to use for lookup of stack widgets
> when requesting WidgetInfo with layouts.
> Create corresponding DAO objects with unit tests
> Create findById and findBySectionName and findByCluster
> Note: There is no direct relationship between the two.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
> 5968b2f
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
> PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9ff62df
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7d62aee
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 78a263f
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
> a06f1d2
> ambari-server/src/main/resources/META-INF/persistence.xml 8c0d85f
>
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserWidgetDAOTest.java
> PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java
> PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32312/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan Kozlov
>
>
