----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32619/#review78345 -----------------------------------------------------------
ambari-server/src/main/python/bootstrap.py <https://reviews.apache.org/r/32619/#comment126904> Please fork at the class level instead of forking every function that differs. It will avoid some of the if-else blocks and also make the code more readable. class Bootstrap(threading.Thread) @OsFamilyImpl(os_family=OsFamilyImpl.DEFAULT) class BootstrapDefault(threading.Thread) @OsFamilyImpl(os_family=OSConst.WINSRV_FAMILY) class BootstrapWindows(threading.Thread) ambari-server/src/main/python/bootstrap.py <https://reviews.apache.org/r/32619/#comment126905> You wont need this if-else if you fork at class level ambari-server/src/main/python/bootstrap.py <https://reviews.apache.org/r/32619/#comment126906> Use constant string instead of hardcoding for Create-RemotingDir.ps1, Run-RemotingScript.ps1, Send-RemotingFile.ps1, Unzip-RemotingFile.ps1 - Jayush Luniya On March 30, 2015, 12:46 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32619/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 12:46 p.m.) > > > Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush > Luniya. > > > Bugs: AMBARI-10271 > https://issues.apache.org/jira/browse/AMBARI-10271 > > > Repository: ambari > > > Description > ------- > > [WinTP2] Agent Automatic Bootstrap: Adapt the bootstrap.py to upload > bootstrap archive to agent node, unzip and run setupAgent script on windows > > > Diffs > ----- > > ambari-server/src/main/assemblies/server-windows.xml 8b5483a > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java > 8c27934 > ambari-server/src/main/python/bootstrap.py 111ff46 > ambari-server/src/main/windows/psremoting/Create-RemotingDir.ps1 > PRE-CREATION > ambari-server/src/main/windows/psremoting/Run-RemotingScript.ps1 > PRE-CREATION > ambari-server/src/main/windows/psremoting/Send-RemotingFile.ps1 > PRE-CREATION > ambari-server/src/main/windows/psremoting/Unzip-RemotingFile.ps1 > PRE-CREATION > > Diff: https://reviews.apache.org/r/32619/diff/ > > > Testing > ------- > > tested manyally > > > Thanks, > > Artem Baranchuk > >
